From 90ef627cc612fc3dfe9c8859d8500c6f4f25a306 Mon Sep 17 00:00:00 2001 From: Erik Berdonces Bonelo Date: Thu, 4 Feb 2021 12:56:09 +0100 Subject: [PATCH 1/5] Use ranges in setup.py versions Versions in setup.py shouldn't be pinned. https://packaging.python.org/discussions/install-requires-vs-requirements/?highlight=install_requires Removed also dev dependencies, as setup.py should only keep the ones used for production. For dev and testing you use the ones in requirements.txt. To understand `~=~ check here: https://pip.pypa.io/en/latest/user_guide/#understanding-your-error-message >~=3.1: version 3.1 or later, but not version 4.0 or later. ~=3.1.2: version 3.1.2 or later, but not version 3.2.0 or later. --- setup.py | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/setup.py b/setup.py index a58a2f1..29cf0dd 100644 --- a/setup.py +++ b/setup.py @@ -46,15 +46,10 @@ setup( python_requires='>=3.0.0, <4', # deps installed by pip install_requires=[ - 'eventemitter==0.2.0', - 'asyncio==3.4.3', - 'websockets==7.0', - 'pylint==2.3.0', - 'pytest-asyncio==0.10.0', - 'six==1.12.0', - 'pyee==8.0.1', - 'aiohttp==3.4.4', - 'isort==4.3.21' + 'eventemitter~=0.2.0', + 'asyncio~=3.0', + 'websockets~=7.0', + 'aiohttp~=3.0', ], project_urls={ 'Bug Reports': 'https://github.com/bitfinexcom/bitfinex-api-py/issues', From 7833feb101131f92b8c3f6ca890f517b4a90ba74 Mon Sep 17 00:00:00 2001 From: Erik Berdonces Bonelo Date: Tue, 9 Feb 2021 17:29:43 +0100 Subject: [PATCH 2/5] Pin pyee to version 7.X.X --- setup.py | 1 + 1 file changed, 1 insertion(+) diff --git a/setup.py b/setup.py index 29cf0dd..d8e26b9 100644 --- a/setup.py +++ b/setup.py @@ -50,6 +50,7 @@ setup( 'asyncio~=3.0', 'websockets~=7.0', 'aiohttp~=3.0', + 'pyee~=7.0' ], project_urls={ 'Bug Reports': 'https://github.com/bitfinexcom/bitfinex-api-py/issues', From c7f5678a5f0f211778b91a689811c9569a25214e Mon Sep 17 00:00:00 2001 From: Erik Berdonces Bonelo Date: Wed, 10 Feb 2021 12:34:52 +0100 Subject: [PATCH 3/5] Pin pyee to ~=8.0 --- setup.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/setup.py b/setup.py index d8e26b9..c82a27b 100644 --- a/setup.py +++ b/setup.py @@ -50,7 +50,7 @@ setup( 'asyncio~=3.0', 'websockets~=7.0', 'aiohttp~=3.0', - 'pyee~=7.0' + 'pyee~=8.0' ], project_urls={ 'Bug Reports': 'https://github.com/bitfinexcom/bitfinex-api-py/issues', From 83b447e4cd03aa189896414a5e83afefc9105bc8 Mon Sep 17 00:00:00 2001 From: Erik Berdonces Bonelo Date: Wed, 10 Feb 2021 16:07:27 +0100 Subject: [PATCH 4/5] Update requirements.txt --- requirements.txt | 1 - 1 file changed, 1 deletion(-) diff --git a/requirements.txt b/requirements.txt index 3997718..2485cb1 100644 --- a/requirements.txt +++ b/requirements.txt @@ -1,4 +1,3 @@ -eventemitter==0.2.0 asyncio==3.4.3 websockets==7.0 pylint==2.3.0 From 7c8ce5c389bf84b51910c5690f9cf07f7bfe22f7 Mon Sep 17 00:00:00 2001 From: Erik Berdonces Bonelo Date: Wed, 10 Feb 2021 16:07:46 +0100 Subject: [PATCH 5/5] Update setup.py --- setup.py | 1 - 1 file changed, 1 deletion(-) diff --git a/setup.py b/setup.py index c82a27b..70e230b 100644 --- a/setup.py +++ b/setup.py @@ -46,7 +46,6 @@ setup( python_requires='>=3.0.0, <4', # deps installed by pip install_requires=[ - 'eventemitter~=0.2.0', 'asyncio~=3.0', 'websockets~=7.0', 'aiohttp~=3.0',