Add tests for adversarial scenarios (#300)

* fix and test cheating scenario (malicious double spend) * test and fix async vtxo cheating cases * add replace statement in go.mod * Update server/internal/core/application/covenantless.go Co-authored-by: Pietralberto Mazza <18440657+altafan@users.noreply.github.com> Signed-off-by: Louis Singer <41042567+louisinger@users.noreply.github.com> * Update server/internal/infrastructure/wallet/btc-embedded/psbt.go Co-authored-by: Pietralberto Mazza <18440657+altafan@users.noreply.github.com> Signed-off-by: Louis Singer <41042567+louisinger@users.noreply.github.com> * Update server/test/e2e/covenant/e2e_test.go Co-authored-by: Pietralberto Mazza <18440657+altafan@users.noreply.github.com> Signed-off-by: Louis Singer <41042567+louisinger@users.noreply.github.com> * Update server/test/e2e/covenantless/e2e_test.go Co-authored-by: Pietralberto Mazza <18440657+altafan@users.noreply.github.com> Signed-off-by: Louis Singer <41042567+louisinger@users.noreply.github.com> * Update server/test/e2e/covenantless/e2e_test.go Co-authored-by: Pietralberto Mazza <18440657+altafan@users.noreply.github.com> Signed-off-by: Louis Singer <41042567+louisinger@users.noreply.github.com> * remove unused * [btc-embedded] fix GetNotificationChannel * [tx-builder] fix redeem transaction fee estimator * close grpc client in tests * [application] rework listentoscannerNotification * [application][covenant] fix getConnectorAmount * [tx-builder][covenant] get connector amount from wallet * e2e test sleep time * [liquid-standalone] ListConnectorUtxos: filter by script client side * fix Makefile integrationtest * do not use cache in integration tests * use VtxoKey as argument of findForfeitTxBitcoin * wrap adversarial test in t.Run * increaste test timeout * CI: setup go 1.23.1 * CI: revert go version * add replace in server/go.mod * Update server/internal/core/application/covenant.go Co-authored-by: Pietralberto Mazza <18440657+altafan@users.noreply.github.com> Signed-off-by: Louis Singer <41042567+louisinger@users.noreply.github.com> * remove replace * readd replace statement * fixes * go work sync * fix CI --------- Signed-off-by: Louis Singer <41042567+louisinger@users.noreply.github.com> Co-authored-by: Pietralberto Mazza <18440657+altafan@users.noreply.github.com>
2025-12-18 20:54:20 +01:00 · 2024-09-16 17:03:43 +02:00
parent 4c8c5c06ed
commit 3782793431
31 changed files with 709 additions and 275 deletions
--- a/server/internal/infrastructure/tx-builder/covenantless/builder.go
+++ b/server/internal/infrastructure/tx-builder/covenantless/builder.go
@@ -102,12 +102,60 @@ func (b *txBuilder) VerifyTapscriptPartialSigs(tx string) (bool, string, error)
 	return true, txid, nil
 }

-func (b *txBuilder) FinalizeAndExtractForfeit(tx string) (string, error) {
-	ptx, _ := psbt.NewFromRawBytes(strings.NewReader(tx), true)
+func (b *txBuilder) FinalizeAndExtract(tx string) (string, error) {
+	ptx, err := psbt.NewFromRawBytes(strings.NewReader(tx), true)
+	if err != nil {
+		return "", err
+	}
+
+	for i, in := range ptx.Inputs {
+		isTaproot := txscript.IsPayToTaproot(in.WitnessUtxo.PkScript)
+		if isTaproot && len(in.TaprootLeafScript) > 0 {
+			closure, err := bitcointree.DecodeClosure(in.TaprootLeafScript[0].Script)
+			if err != nil {
+				return "", err
+			}
+
+			witness := make(wire.TxWitness, 4)
+
+			castClosure, isTaprootMultisig := closure.(*bitcointree.MultisigClosure)
+			if isTaprootMultisig {
+				ownerPubkey := schnorr.SerializePubKey(castClosure.Pubkey)
+				aspKey := schnorr.SerializePubKey(castClosure.AspPubkey)
+
+				for _, sig := range in.TaprootScriptSpendSig {
+					if bytes.Equal(sig.XOnlyPubKey, ownerPubkey) {
+						witness[0] = sig.Signature
+					}
+
+					if bytes.Equal(sig.XOnlyPubKey, aspKey) {
+						witness[1] = sig.Signature
+					}
+				}
+
+				witness[2] = in.TaprootLeafScript[0].Script
+				witness[3] = in.TaprootLeafScript[0].ControlBlock
+
+				for idw, w := range witness {
+					if w == nil {
+						return "", fmt.Errorf("missing witness element %d, cannot finalize taproot mutlisig input %d", idw, i)
+					}
+				}
+
+				var witnessBuf bytes.Buffer
+
+				if err := psbt.WriteTxWitness(&witnessBuf, witness); err != nil {
+					return "", err
+				}
+
+				ptx.Inputs[i].FinalScriptWitness = witnessBuf.Bytes()
+				continue
+			}
+
+		}

-	for i := range ptx.Inputs {
 		if err := psbt.Finalize(ptx, i); err != nil {
-			return "", err
+			return "", fmt.Errorf("failed to finalize input %d: %w", i, err)
 		}
 	}

@@ -477,7 +525,7 @@ func (b *txBuilder) BuildAsyncPaymentTransactions(

 		unconditionalForfeitTxs = append(unconditionalForfeitTxs, forfeitTx)
 		ins = append(ins, vtxoOutpoint)
-		redeemTxWeightEstimator.AddTapscriptInput(64, tapscript)
+		redeemTxWeightEstimator.AddTapscriptInput(64*2, tapscript)
 	}

 	for range receivers {
@@ -1199,7 +1247,7 @@ func (b *txBuilder) getConnectorPkScript(poolTx string) ([]byte, error) {
 		return nil, fmt.Errorf("connector output not found in pool tx")
 	}

-	return partialTx.UnsignedTx.TxOut[0].PkScript, nil
+	return partialTx.UnsignedTx.TxOut[1].PkScript, nil
 }

 func (b *txBuilder) selectUtxos(ctx context.Context, sweptRounds []domain.Round, amount uint64) ([]ports.TxInput, uint64, error) {