From f56d653d22832eb03f6a2fde8337683dcc47dea1 Mon Sep 17 00:00:00 2001
From: Franck Nijhof <git@frenck.dev>
Date: Wed, 18 Dec 2019 13:54:57 +0100
Subject: [PATCH] duckdns: Collection of improvements (#900)

* duckdns: Prettier YAML files

* duckdns: Sort build.json

* duckdns: Update add-on URL

* duckdns: Remove curl from Dockerfile, part of base image

* duckdns: Small style change to Dockerfile

* duckdns: Documents missing ipv4 & ipv6 options
---
 duckdns/Dockerfile          |  5 +++--
 duckdns/README.md           | 12 ++++++++++++
 duckdns/azure-pipelines.yml | 15 +++++++--------
 duckdns/build.json          |  4 ++--
 duckdns/config.json         |  2 +-
 5 files changed, 25 insertions(+), 13 deletions(-)

diff --git a/duckdns/Dockerfile b/duckdns/Dockerfile
index f56c08b..a639c87 100644
--- a/duckdns/Dockerfile
+++ b/duckdns/Dockerfile
@@ -3,8 +3,9 @@ FROM $BUILD_FROM
 
 # Setup base
 ARG DEHYDRATED_VERSION
-RUN apk add --no-cache curl openssl \
-  && curl -s -o /usr/bin/dehydrated https://raw.githubusercontent.com/lukas2511/dehydrated/v$DEHYDRATED_VERSION/dehydrated \
+RUN apk add --no-cache openssl \
+  && curl -s -o /usr/bin/dehydrated \
+    "https://raw.githubusercontent.com/lukas2511/dehydrated/v${DEHYDRATED_VERSION}/dehydrated" \
   && chmod a+x /usr/bin/dehydrated
 
 # Copy data
diff --git a/duckdns/README.md b/duckdns/README.md
index dd78a62..679fcda 100644
--- a/duckdns/README.md
+++ b/duckdns/README.md
@@ -63,6 +63,18 @@ The name of the private key file generated by Let's Encrypt. The private key fil
 
 **Note**: _The file is stored in `/ssl/`, which is the default for Hass.io_
 
+### Option: `ipv4` (optional)
+
+By default, Duck DNS will auto detect your IPv4 address and use that.
+This option allows you to override the auto-detection and specify an
+IPv4 address manually.
+
+### Option: `ipv6` (optional)
+
+By default, Duck DNS will auto detect your IPv6 address and use that.
+This option allows you to override the auto-detection and specify an
+IPv6 address manually.
+
 ### Option: `token`
 
 The DuckDNS authentication token found at the top of the DuckDNS account landing page. The token is required to make any changes to the subdomains registered to your account.
diff --git a/duckdns/azure-pipelines.yml b/duckdns/azure-pipelines.yml
index 4e2e9a0..ef96f5d 100644
--- a/duckdns/azure-pipelines.yml
+++ b/duckdns/azure-pipelines.yml
@@ -3,20 +3,19 @@
 trigger:
   branches:
     include:
-    - master
+      - master
   paths:
     include:
-    - duckdns/*
+      - duckdns/*
 pr: none
 
 variables:
   - name: versionBuilder
-    value: '2.0'
+    value: "2.0"
   - group: docker
 
-
 jobs:
-- template: /.azure/azp-template-addon.yml
-  parameters:
-    addon: 'duckdns'
-    arch: '--all'
+  - template: /.azure/azp-template-addon.yml
+    parameters:
+      addon: "duckdns"
+      arch: "--all"
diff --git a/duckdns/build.json b/duckdns/build.json
index 9bbf6de..ee1d570 100644
--- a/duckdns/build.json
+++ b/duckdns/build.json
@@ -1,10 +1,10 @@
 {
   "build_from": {
+    "aarch64": "homeassistant/aarch64-base:3.10",
     "amd64": "homeassistant/amd64-base:3.10",
-    "i386": "homeassistant/i386-base:3.10",
     "armhf": "homeassistant/armhf-base:3.10",
     "armv7": "homeassistant/armv7-base:3.10",
-    "aarch64": "homeassistant/aarch64-base:3.10"
+    "i386": "homeassistant/i386-base:3.10"
   },
   "args": {
     "DEHYDRATED_VERSION": "0.6.5"
diff --git a/duckdns/config.json b/duckdns/config.json
index d51c72d..ce2f997 100644
--- a/duckdns/config.json
+++ b/duckdns/config.json
@@ -3,7 +3,7 @@
   "version": "1.10",
   "slug": "duckdns",
   "description": "Free Dynamic DNS (DynDNS or DDNS) service with Let's Encrypt support",
-  "url": "https://www.home-assistant.io/addons/duckdns/",
+  "url": "https://github.com/home-assistant/hassio-addons/tree/master/duckdns",
   "arch": ["armhf", "armv7", "aarch64", "amd64", "i386"],
   "startup": "services",
   "boot": "auto",