aljaz/Interlace
1
1
Fork 0
mirror of https://github.com/codingo/Interlace.git synced 2025-12-17 14:54:21 +01:00
Code Issues Packages Projects Releases Wiki Activity

Update check_positive method to handle ValueError exception.

Browse Source 
I saw that, despite you're testing if the thread argument is positive, you're not testing if it's a number, so "ivalue = int(arg)" can cause an exception if I pass an argument like "--thread abc". I didn't have much time to chack if you test this somewhere else, but I think you don't. Thanks for the opportunity! I hope I can help.
This commit is contained in:
ualvesdias
2020-03-11 17:18:45 -03:00
committed by GitHub
parent 5a3901e700
commit 0e70d37a42
1 changed files with 6 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
Interlace/lib/core/input.py
View File

@@ -19,9 +19,12 @@ class InputHelper(object):
@staticmethod @staticmethod
def check_positive(parser, arg): def check_positive(parser, arg):
ivalue = int(arg) try:
if ivalue <= 0: ivalue = int(arg)
raise parser.ArgumentTypeError("%s is not a valid positive integer!" % arg) if ivalue <= 0:
raise parser.ArgumentTypeError("%s is not a valid positive integer!" % arg)
except ValueError as e:
raise parser.ArgumentValueError("%s is not a a number!" % arg)
return arg return arg