From 1cc288af39f171b3e7f77fdb4252682af05e17e9 Mon Sep 17 00:00:00 2001 From: Ryan Russell Date: Wed, 1 Jun 2022 15:28:02 -0500 Subject: [PATCH] Improve Readability (#133) Signed-off-by: Ryan Russell --- README.md | 4 ++-- configs/README.md | 2 +- dalle2_pytorch/dataloaders/README.md | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/README.md b/README.md index 9294b5c..043c29a 100644 --- a/README.md +++ b/README.md @@ -943,7 +943,7 @@ from dalle2_pytorch.dataloaders import ImageEmbeddingDataset, create_image_embed # Create a dataloader directly. dataloader = create_image_embedding_dataloader( - tar_url="/path/or/url/to/webdataset/{0000..9999}.tar", # Uses braket expanding notation. This specifies to read all tars from 0000.tar to 9999.tar + tar_url="/path/or/url/to/webdataset/{0000..9999}.tar", # Uses bracket expanding notation. This specifies to read all tars from 0000.tar to 9999.tar embeddings_url="path/or/url/to/embeddings/folder", # Included if .npy files are not in webdataset. Left out or set to None otherwise num_workers=4, batch_size=32, @@ -1097,7 +1097,7 @@ This library would not have gotten to this working state without the help of - [ ] test out grid attention in cascading ddpm locally, decide whether to keep or remove https://arxiv.org/abs/2204.01697 - [ ] interface out the vqgan-vae so a pretrained one can be pulled off the shelf to validate latent diffusion + DALL-E2 - [ ] make sure FILIP works with DALL-E2 from x-clip https://arxiv.org/abs/2111.07783 -- [ ] bring in skip-layer excitatons (from lightweight gan paper) to see if it helps for either decoder of unet or vqgan-vae training +- [ ] bring in skip-layer excitations (from lightweight gan paper) to see if it helps for either decoder of unet or vqgan-vae training - [ ] decoder needs one day worth of refactor for tech debt - [ ] allow for unet to be able to condition non-cross attention style as well - [ ] read the paper, figure it out, and build it https://github.com/lucidrains/DALLE2-pytorch/issues/89 diff --git a/configs/README.md b/configs/README.md index 36c783f..07dc76d 100644 --- a/configs/README.md +++ b/configs/README.md @@ -83,7 +83,7 @@ Defines which evaluation metrics will be used to test the model. Each metric can be enabled by setting its configuration. The configuration keys for each metric are defined by the torchmetrics constructors which will be linked. | Option | Required | Default | Description | | ------ | -------- | ------- | ----------- | -| `n_evalation_samples` | No | `1000` | The number of samples to generate to test the model. | +| `n_evaluation_samples` | No | `1000` | The number of samples to generate to test the model. | | `FID` | No | `None` | Setting to an object enables the [Frechet Inception Distance](https://torchmetrics.readthedocs.io/en/stable/image/frechet_inception_distance.html) metric. | `IS` | No | `None` | Setting to an object enables the [Inception Score](https://torchmetrics.readthedocs.io/en/stable/image/inception_score.html) metric. | `KID` | No | `None` | Setting to an object enables the [Kernel Inception Distance](https://torchmetrics.readthedocs.io/en/stable/image/kernel_inception_distance.html) metric. | diff --git a/dalle2_pytorch/dataloaders/README.md b/dalle2_pytorch/dataloaders/README.md index c61e730..66f3c90 100644 --- a/dalle2_pytorch/dataloaders/README.md +++ b/dalle2_pytorch/dataloaders/README.md @@ -15,7 +15,7 @@ from dalle2_pytorch.dataloaders import ImageEmbeddingDataset, create_image_embed # Create a dataloader directly. dataloader = create_image_embedding_dataloader( - tar_url="/path/or/url/to/webdataset/{0000..9999}.tar", # Uses braket expanding notation. This specifies to read all tars from 0000.tar to 9999.tar + tar_url="/path/or/url/to/webdataset/{0000..9999}.tar", # Uses bracket expanding notation. This specifies to read all tars from 0000.tar to 9999.tar embeddings_url="path/or/url/to/embeddings/folder", # Included if .npy files are not in webdataset. Left out or set to None otherwise num_workers=4, batch_size=32,