mirror of
https://github.com/aljazceru/CTFd.git
synced 2025-12-17 05:54:19 +01:00
Alpha release of CTFd v3.
# 3.0.0a1 / 2020-07-01
**General**
- CTFd is now Python 3 only
- Render markdown with the CommonMark spec provided by `cmarkgfm`
- Render markdown stripped of any malicious JavaScript or HTML.
- This is a significant change from previous versions of CTFd where any HTML content from an admin was considered safe.
- Inject `Config`, `User`, `Team`, `Session`, and `Plugin` globals into Jinja
- User sessions no longer store any user-specific attributes.
- Sessions only store the user's ID, CSRF nonce, and an hmac of the user's password
- This allows for session invalidation on password changes
- The user facing side of CTFd now has user and team searching
- GeoIP support now available for converting IP addresses to guessed countries
**Admin Panel**
- Use EasyMDE as an improved description/text editor for Markdown enabled fields.
- Media Library button now integrated into EasyMDE enabled fields
- VueJS now used as the underlying implementation for the Media Library
- Fix setting theme color in Admin Panel
- Green outline border has been removed from the Admin Panel
**API**
- Significant overhauls in API documentation provided by Swagger UI and Swagger json
- Make almost all API endpoints provide filtering and searching capabilities
- Change `GET /api/v1/config/<config_key>` to return structured data according to ConfigSchema
**Themes**
- Themes now have access to the `Configs` global which provides wrapped access to `get_config`.
- For example, `{{ Configs.ctf_name }}` instead of `get_ctf_name()` or `get_config('ctf_name')`
- Themes must now specify a `challenge.html` which control how a challenge should look.
- The main library for charts has been changed from Plotly to Apache ECharts.
- Forms have been moved into wtforms for easier form rendering inside of Jinja.
- From Jinja you can access forms via the Forms global i.e. `{{ Forms }}`
- This allows theme developers to more easily re-use a form without having to copy-paste HTML.
- Themes can now provide a theme settings JSON blob which can be injected into the theme with `{{ Configs.theme_settings }}`
- Core theme now includes the challenge ID in location hash identifiers to always refer the right challenge despite duplicate names
**Plugins**
- Challenge plugins have changed in structure to better allow integration with themes and prevent obtrusive Javascript/XSS.
- Challenge rendering now uses `challenge.html` from the provided theme.
- Accessing the challenge view content is now provided by `/api/v1/challenges/<challenge_id>` in the `view` section. This allows for HTML to be properly sanitized and rendered by the server allowing CTFd to remove client side Jinja rendering.
- `challenge.html` now specifies what's required and what's rendered by the theme. This allows the challenge plugin to avoid having to deal with aspects of the challenge besides the description and input.
- A more complete migration guide will be provided when CTFd v3 leaves beta
- Display current attempt count in challenge view when max attempts is enabled
- `get_standings()`, `get_team_stanadings()`, `get_user_standings()` now has a fields keyword argument that allows for specificying additional fields that SQLAlchemy should return when building the response set.
- Useful for gathering additional data when building scoreboard pages
- Flags can now control the message that is shown to the user by raising `FlagException`
- Fix `override_template()` functionality
**Deployment**
- Enable SQLAlchemy's `pool_pre_ping` by default to reduce the likelihood of database connection issues
- Mailgun email settings are now deprecated. Admins should move to SMTP email settings instead.
- Postgres is now considered a second class citizen in CTFd. It is tested against but not a main database backend. If you use Postgres, you are entirely on your own with regards to supporting CTFd.
- Docker image now uses Debian instead of Alpine. See https://github.com/CTFd/CTFd/issues/1215 for rationale.
- `docker-compose.yml` now uses a non-root user to connect to MySQL/MariaDB
- `config.py` should no longer be editting for configuration, instead edit `config.ini` or the environment variables in `docker-compose.yml`
205 lines
7.3 KiB
Python
205 lines
7.3 KiB
Python
#!/usr/bin/env python
|
|
# -*- coding: utf-8 -*-
|
|
|
|
from CTFd.plugins import (
|
|
bypass_csrf_protection,
|
|
get_admin_plugin_menu_bar,
|
|
get_user_page_menu_bar,
|
|
override_template,
|
|
register_admin_plugin_menu_bar,
|
|
register_admin_plugin_script,
|
|
register_admin_plugin_stylesheet,
|
|
register_plugin_asset,
|
|
register_plugin_assets_directory,
|
|
register_plugin_script,
|
|
register_user_page_menu_bar,
|
|
)
|
|
from tests.helpers import create_ctfd, destroy_ctfd, login_as_user, setup_ctfd
|
|
|
|
|
|
def test_register_plugin_asset():
|
|
"""Test that plugin asset registration works"""
|
|
app = create_ctfd(setup=False)
|
|
register_plugin_asset(app, asset_path="/plugins/__init__.py")
|
|
app = setup_ctfd(app)
|
|
with app.app_context():
|
|
with app.test_client() as client:
|
|
r = client.get("/plugins/__init__.py")
|
|
assert len(r.get_data(as_text=True)) > 0
|
|
assert r.status_code == 200
|
|
destroy_ctfd(app)
|
|
|
|
|
|
def test_register_plugin_assets_directory():
|
|
"""Test that plugin asset directory registration works"""
|
|
app = create_ctfd(setup=False)
|
|
register_plugin_assets_directory(app, base_path="/plugins/")
|
|
app = setup_ctfd(app)
|
|
with app.app_context():
|
|
with app.test_client() as client:
|
|
r = client.get("/plugins/__init__.py")
|
|
assert len(r.get_data(as_text=True)) > 0
|
|
assert r.status_code == 200
|
|
r = client.get("/plugins/challenges/__init__.py")
|
|
assert len(r.get_data(as_text=True)) > 0
|
|
assert r.status_code == 200
|
|
destroy_ctfd(app)
|
|
|
|
|
|
def test_override_template():
|
|
"""Does override_template work properly for regular themes when used from a plugin"""
|
|
app = create_ctfd()
|
|
with app.app_context():
|
|
override_template("login.html", "LOGIN OVERRIDE")
|
|
with app.test_client() as client:
|
|
r = client.get("/login")
|
|
assert r.status_code == 200
|
|
output = r.get_data(as_text=True)
|
|
assert "LOGIN OVERRIDE" in output
|
|
destroy_ctfd(app)
|
|
|
|
|
|
def test_admin_override_template():
|
|
"""Does override_template work properly for the admin panel when used from a plugin"""
|
|
app = create_ctfd()
|
|
with app.app_context():
|
|
override_template("admin/users/user.html", "ADMIN USER OVERRIDE")
|
|
|
|
client = login_as_user(app, name="admin", password="password")
|
|
r = client.get("/admin/users/1")
|
|
assert r.status_code == 200
|
|
output = r.get_data(as_text=True)
|
|
assert "ADMIN USER OVERRIDE" in output
|
|
destroy_ctfd(app)
|
|
|
|
|
|
def test_register_plugin_script():
|
|
"""Test that register_plugin_script adds script paths to the core theme when used from a plugin"""
|
|
app = create_ctfd()
|
|
with app.app_context():
|
|
register_plugin_script("/fake/script/path.js")
|
|
register_plugin_script("http://ctfd.io/fake/script/path.js")
|
|
with app.test_client() as client:
|
|
r = client.get("/")
|
|
output = r.get_data(as_text=True)
|
|
assert "/fake/script/path.js" in output
|
|
assert "http://ctfd.io/fake/script/path.js" in output
|
|
destroy_ctfd(app)
|
|
|
|
|
|
def test_register_plugin_stylesheet():
|
|
"""Test that register_plugin_stylesheet adds stylesheet paths to the core theme when used from a plugin"""
|
|
app = create_ctfd()
|
|
with app.app_context():
|
|
register_plugin_script("/fake/stylesheet/path.css")
|
|
register_plugin_script("http://ctfd.io/fake/stylesheet/path.css")
|
|
with app.test_client() as client:
|
|
r = client.get("/")
|
|
output = r.get_data(as_text=True)
|
|
assert "/fake/stylesheet/path.css" in output
|
|
assert "http://ctfd.io/fake/stylesheet/path.css" in output
|
|
destroy_ctfd(app)
|
|
|
|
|
|
def test_register_admin_plugin_script():
|
|
"""Test that register_admin_plugin_script adds script paths to the admin theme when used from a plugin"""
|
|
app = create_ctfd()
|
|
with app.app_context():
|
|
register_admin_plugin_script("/fake/script/path.js")
|
|
register_admin_plugin_script("http://ctfd.io/fake/script/path.js")
|
|
with login_as_user(app, name="admin") as client:
|
|
r = client.get("/admin/statistics")
|
|
output = r.get_data(as_text=True)
|
|
assert "/fake/script/path.js" in output
|
|
assert "http://ctfd.io/fake/script/path.js" in output
|
|
destroy_ctfd(app)
|
|
|
|
|
|
def test_register_admin_plugin_stylesheet():
|
|
"""Test that register_admin_plugin_stylesheet adds stylesheet paths to the admin theme when used from a plugin"""
|
|
app = create_ctfd()
|
|
with app.app_context():
|
|
register_admin_plugin_stylesheet("/fake/stylesheet/path.css")
|
|
register_admin_plugin_stylesheet("http://ctfd.io/fake/stylesheet/path.css")
|
|
with login_as_user(app, name="admin") as client:
|
|
r = client.get("/admin/statistics")
|
|
output = r.get_data(as_text=True)
|
|
assert "/fake/stylesheet/path.css" in output
|
|
assert "http://ctfd.io/fake/stylesheet/path.css" in output
|
|
destroy_ctfd(app)
|
|
|
|
|
|
def test_register_admin_plugin_menu_bar():
|
|
"""
|
|
Test that register_admin_plugin_menu_bar() properly inserts into HTML and get_admin_plugin_menu_bar()
|
|
returns the proper list.
|
|
"""
|
|
app = create_ctfd()
|
|
with app.app_context():
|
|
register_admin_plugin_menu_bar(
|
|
title="test_admin_plugin_name", route="/test_plugin"
|
|
)
|
|
|
|
client = login_as_user(app, name="admin", password="password")
|
|
r = client.get("/admin/statistics")
|
|
output = r.get_data(as_text=True)
|
|
assert "/test_plugin" in output
|
|
assert "test_admin_plugin_name" in output
|
|
|
|
menu_item = get_admin_plugin_menu_bar()[0]
|
|
assert menu_item.title == "test_admin_plugin_name"
|
|
assert menu_item.route == "http://localhost/test_plugin"
|
|
destroy_ctfd(app)
|
|
|
|
|
|
def test_register_user_page_menu_bar():
|
|
"""
|
|
Test that the register_user_page_menu_bar() properly inserts into HTML and get_user_page_menu_bar() returns the
|
|
proper list.
|
|
"""
|
|
app = create_ctfd()
|
|
with app.app_context():
|
|
register_user_page_menu_bar(
|
|
title="test_user_menu_link", route="/test_user_href"
|
|
)
|
|
|
|
with app.test_client() as client:
|
|
r = client.get("/")
|
|
|
|
output = r.get_data(as_text=True)
|
|
assert "/test_user_href" in output
|
|
assert "test_user_menu_link" in output
|
|
|
|
menu_item = get_user_page_menu_bar()[0]
|
|
assert menu_item.title == "test_user_menu_link"
|
|
assert menu_item.route == "http://localhost/test_user_href"
|
|
destroy_ctfd(app)
|
|
|
|
|
|
def test_bypass_csrf_protection():
|
|
"""
|
|
Test that the bypass_csrf_protection decorator functions properly
|
|
"""
|
|
app = create_ctfd()
|
|
|
|
with app.app_context():
|
|
with app.test_client() as client:
|
|
r = client.post("/login")
|
|
output = r.get_data(as_text=True)
|
|
assert r.status_code == 403
|
|
|
|
def bypass_csrf_protection_test_route():
|
|
return "Success", 200
|
|
|
|
# Hijack an existing route to avoid any kind of hacks to create a test route
|
|
app.view_functions["auth.login"] = bypass_csrf_protection(
|
|
bypass_csrf_protection_test_route
|
|
)
|
|
|
|
with app.test_client() as client:
|
|
r = client.post("/login")
|
|
output = r.get_data(as_text=True)
|
|
assert r.status_code == 200
|
|
assert output == "Success"
|
|
destroy_ctfd(app)
|