aljaz/CTFd
1
0
Fork 0
mirror of https://github.com/aljazceru/CTFd.git synced 2025-12-17 05:54:19 +01:00
Code Issues Packages Projects Releases Wiki Activity

Null out some functions in view.js (#2105)

Browse Source 
* Remove some unused functions from the default provided standard & dynamic challenge `view.js` files
This commit is contained in:
Kevin Chung
2022-04-30 22:05:16 -04:00
committed by GitHub
parent 073d4b7cf9
commit f3e43d97a6
3 changed files with 59 additions and 60 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
CHANGELOG.md
View File

@@ -41,6 +41,11 @@
- No longer install `python3-dev` in Dockerfile
- docker-compose.yml now uses `nginx:stable` as the image for nginx
**Plugins**
- `CTFd._internal.challenge.render` and `CTFd._internal.challenge.renderer` in `view.js` Challenge type files have been deprecated. Instead Challenge plugins should refer to the `challenge.html` data provided by the API.
- Essentially CTFd is moving to having markdown & HTML rendered by the server.
**Themes**
- Create the `core-beta` theme and begin documenting the creation of themes using Vite

43
CTFd/plugins/challenges/assets/view.js
View File

@@ -1,40 +1,37 @@
CTFd._internal.challenge.data = undefined
CTFd._internal.challenge.data = undefined;
CTFd._internal.challenge.renderer = CTFd.lib.markdown();
// TODO: Remove in CTFd v4.0
CTFd._internal.challenge.renderer = null;
CTFd._internal.challenge.preRender = function() {};
CTFd._internal.challenge.preRender = function () { }
// TODO: Remove in CTFd v4.0
CTFd._internal.challenge.render = null;
CTFd._internal.challenge.render = function (markdown) {
return CTFd._internal.challenge.renderer.render(markdown)
}
CTFd._internal.challenge.postRender = function() {};
CTFd._internal.challenge.postRender = function () { }
CTFd._internal.challenge.submit = function (preview) {
var challenge_id = parseInt(CTFd.lib.$('#challenge-id').val())
var submission = CTFd.lib.$('#challenge-input').val()
CTFd._internal.challenge.submit = function(preview) {
var challenge_id = parseInt(CTFd.lib.$("#challenge-id").val());
var submission = CTFd.lib.$("#challenge-input").val();
var body = {
'challenge_id': challenge_id,
'submission': submission,
}
var params = {}
challenge_id: challenge_id,
submission: submission
};
var params = {};
if (preview) {
params['preview'] = true
params["preview"] = true;
}
return CTFd.api.post_challenge_attempt(params, body).then(function (response) {
return CTFd.api.post_challenge_attempt(params, body).then(function(response) {
if (response.status === 429) {
// User was ratelimited but process response
return response
return response;
}
if (response.status === 403) {
// User is not logged in or CTF is paused.
return response
return response;
}
return response
})
return response;
});
};

43
CTFd/plugins/dynamic_challenges/assets/view.js
View File

@@ -1,40 +1,37 @@
CTFd._internal.challenge.data = undefined
CTFd._internal.challenge.data = undefined;
CTFd._internal.challenge.renderer = CTFd.lib.markdown();
// TODO: Remove in CTFd v4.0
CTFd._internal.challenge.renderer = null;
CTFd._internal.challenge.preRender = function() {};
CTFd._internal.challenge.preRender = function () { }
// TODO: Remove in CTFd v4.0
CTFd._internal.challenge.render = null;
CTFd._internal.challenge.render = function (markdown) {
return CTFd._internal.challenge.renderer.render(markdown)
}
CTFd._internal.challenge.postRender = function() {};
CTFd._internal.challenge.postRender = function () { }
CTFd._internal.challenge.submit = function (preview) {
var challenge_id = parseInt(CTFd.lib.$('#challenge-id').val())
var submission = CTFd.lib.$('#challenge-input').val()
CTFd._internal.challenge.submit = function(preview) {
var challenge_id = parseInt(CTFd.lib.$("#challenge-id").val());
var submission = CTFd.lib.$("#challenge-input").val();
var body = {
'challenge_id': challenge_id,
'submission': submission,
}
var params = {}
challenge_id: challenge_id,
submission: submission
};
var params = {};
if (preview) {
params['preview'] = true
params["preview"] = true;
}
return CTFd.api.post_challenge_attempt(params, body).then(function (response) {
return CTFd.api.post_challenge_attempt(params, body).then(function(response) {
if (response.status === 429) {
// User was ratelimited but process response
return response
return response;
}
if (response.status === 403) {
// User is not logged in or CTF is paused.
return response
return response;
}
return response
})
return response;
});
};