Require passwords on accounts (#1754)

- Fixed an issue where Users/Teams could be created with a null password through the Admin Panel

CHANGELOG.md

@@ -63,6 +63,7 @@
 - Examples for regex flags are now provided
 - Wrong submissions has been renamed to Incorrect Submissions
 - Graphs in the Admin Statistics page will now scroll with mouse wheel to improve browsing large datasets
+- Fixed an issue where Users/Teams could be created with a null password
 
 **Deployment**
 

CTFd/schemas/teams.py

@@ -33,6 +33,7 @@ class TeamSchema(ma.ModelSchema):
         allow_none=False,
         validate=validate.Email("Emails must be a properly formatted email address"),
     )
+    password = field_for(Teams, "password", required=True, allow_none=False)
     website = field_for(
         Teams,
         "website",

CTFd/schemas/users.py

@@ -51,7 +51,7 @@ class UserSchema(ma.ModelSchema):
         ],
     )
     country = field_for(Users, "country", validate=[validate_country_code])
-    password = field_for(Users, "password")
+    password = field_for(Users, "password", required=True, allow_none=False)
     fields = Nested(
         UserFieldEntriesSchema, partial=True, many=True, attribute="field_entries"
     )