aljaz/CTFd
1
0
Fork 0
mirror of https://github.com/aljazceru/CTFd.git synced 2025-12-17 05:54:19 +01:00
Code Issues Packages Projects Releases Wiki Activity

Adds ondelete='CASCADE' to some models. (#979)

Browse Source 
* Fixes `populate.py` to assign captains to teams.
* Adds `ondelete='CASCADE'` to most ForeignKeys in models
    * Closes #794 
* Test reset in team mode to test removing teams with captains
* Test deleting users/teams with awards to test cascading deletion
* `gen_team()` test helper now creates users for the team and assigns the first one as captain
* Added `Challenges.flags` relationship and moved the `Flags.challenge` relationship to a backref on `Challenges`
This commit is contained in:
Kevin Chung
2019-05-04 02:08:26 -04:00
committed by GitHub
parent 6fcf143392
commit d2f8b4090d
9 changed files with 334 additions and 64 deletions
Download Patch File Download Diff File Expand all files Collapse all files

140
migrations/versions/b295b033364d_add_ondelete_cascade_to_foreign_keys.py Normal file
View File

@@ -0,0 +1,140 @@
"""Add ondelete cascade to foreign keys
Revision ID: b295b033364d
Revises: b5551cd26764
Create Date: 2019-05-03 19:26:57.746887
"""
from alembic import op
import sqlalchemy as sa
from sqlalchemy.dialects import mysql
# revision identifiers, used by Alembic.
revision = 'b295b033364d'
down_revision = 'b5551cd26764'
branch_labels = None
depends_on = None
def upgrade():
bind = op.get_bind()
url = str(bind.engine.url)
if url.startswith('mysql'):
op.drop_constraint('awards_ibfk_1', 'awards', type_='foreignkey')
op.drop_constraint('awards_ibfk_2', 'awards', type_='foreignkey')
op.create_foreign_key('awards_ibfk_1', 'awards', 'teams', ['team_id'], ['id'], ondelete='CASCADE')
op.create_foreign_key('awards_ibfk_2', 'awards', 'users', ['user_id'], ['id'], ondelete='CASCADE')
op.drop_constraint('files_ibfk_1', 'files', type_='foreignkey')
op.create_foreign_key('files_ibfk_1', 'files', 'challenges', ['challenge_id'], ['id'], ondelete='CASCADE')
op.drop_constraint('flags_ibfk_1', 'flags', type_='foreignkey')
op.create_foreign_key('flags_ibfk_1', 'flags', 'challenges', ['challenge_id'], ['id'], ondelete='CASCADE')
op.drop_constraint('hints_ibfk_1', 'hints', type_='foreignkey')
op.create_foreign_key('hints_ibfk_1', 'hints', 'challenges', ['challenge_id'], ['id'], ondelete='CASCADE')
op.drop_constraint('tags_ibfk_1', 'tags', type_='foreignkey')
op.create_foreign_key('tags_ibfk_1', 'tags', 'challenges', ['challenge_id'], ['id'], ondelete='CASCADE')
op.drop_constraint('team_captain_id', 'teams', type_='foreignkey')
op.create_foreign_key('team_captain_id', 'teams', 'users', ['captain_id'], ['id'], ondelete='SET NULL')
op.drop_constraint('tracking_ibfk_1', 'tracking', type_='foreignkey')
op.create_foreign_key('tracking_ibfk_1', 'tracking', 'users', ['user_id'], ['id'], ondelete='CASCADE')
op.drop_constraint('unlocks_ibfk_1', 'unlocks', type_='foreignkey')
op.drop_constraint('unlocks_ibfk_2', 'unlocks', type_='foreignkey')
op.create_foreign_key('unlocks_ibfk_1', 'unlocks', 'teams', ['team_id'], ['id'], ondelete='CASCADE')
op.create_foreign_key('unlocks_ibfk_2', 'unlocks', 'users', ['user_id'], ['id'], ondelete='CASCADE')
elif url.startswith('postgres'):
op.drop_constraint('awards_team_id_fkey', 'awards', type_='foreignkey')
op.drop_constraint('awards_user_id_fkey', 'awards', type_='foreignkey')
op.create_foreign_key('awards_team_id_fkey', 'awards', 'teams', ['team_id'], ['id'], ondelete='CASCADE')
op.create_foreign_key('awards_user_id_fkey', 'awards', 'users', ['user_id'], ['id'], ondelete='CASCADE')
op.drop_constraint('files_challenge_id_fkey', 'files', type_='foreignkey')
op.create_foreign_key('files_challenge_id_fkey', 'files', 'challenges', ['challenge_id'], ['id'], ondelete='CASCADE')
op.drop_constraint('flags_challenge_id_fkey', 'flags', type_='foreignkey')
op.create_foreign_key('flags_challenge_id_fkey', 'flags', 'challenges', ['challenge_id'], ['id'], ondelete='CASCADE')
op.drop_constraint('hints_challenge_id_fkey', 'hints', type_='foreignkey')
op.create_foreign_key('hints_challenge_id_fkey', 'hints', 'challenges', ['challenge_id'], ['id'], ondelete='CASCADE')
op.drop_constraint('tags_challenge_id_fkey', 'tags', type_='foreignkey')
op.create_foreign_key('tags_challenge_id_fkey', 'tags', 'challenges', ['challenge_id'], ['id'], ondelete='CASCADE')
op.drop_constraint('team_captain_id', 'teams', type_='foreignkey')
op.create_foreign_key('team_captain_id', 'teams', 'users', ['captain_id'], ['id'], ondelete='SET NULL')
op.drop_constraint('tracking_user_id_fkey', 'tracking', type_='foreignkey')
op.create_foreign_key('tracking_user_id_fkey', 'tracking', 'users', ['user_id'], ['id'], ondelete='CASCADE')
op.drop_constraint('unlocks_team_id_fkey', 'unlocks', type_='foreignkey')
op.drop_constraint('unlocks_user_id_fkey', 'unlocks', type_='foreignkey')
op.create_foreign_key('unlocks_team_id_fkey', 'unlocks', 'teams', ['team_id'], ['id'], ondelete='CASCADE')
op.create_foreign_key('unlocks_user_id_fkey', 'unlocks', 'users', ['user_id'], ['id'], ondelete='CASCADE')
def downgrade():
bind = op.get_bind()
url = str(bind.engine.url)
if url.startswith('mysql'):
op.drop_constraint('unlocks_ibfk_1', 'unlocks', type_='foreignkey')
op.drop_constraint('unlocks_ibfk_2', 'unlocks', type_='foreignkey')
op.create_foreign_key('unlocks_ibfk_1', 'unlocks', 'teams', ['team_id'], ['id'])
op.create_foreign_key('unlocks_ibfk_2', 'unlocks', 'users', ['user_id'], ['id'])
op.drop_constraint('tracking_ibfk_1', 'tracking', type_='foreignkey')
op.create_foreign_key('tracking_ibfk_1', 'tracking', 'users', ['user_id'], ['id'])
op.drop_constraint('team_captain_id', 'teams', type_='foreignkey')
op.create_foreign_key('team_captain_id', 'teams', 'users', ['captain_id'], ['id'])
op.drop_constraint('tags_ibfk_1', 'tags', type_='foreignkey')
op.create_foreign_key('tags_ibfk_1', 'tags', 'challenges', ['challenge_id'], ['id'])
op.drop_constraint('hints_ibfk_1', 'hints', type_='foreignkey')
op.create_foreign_key('hints_ibfk_1', 'hints', 'challenges', ['challenge_id'], ['id'])
op.drop_constraint('flags_ibfk_1', 'flags', type_='foreignkey')
op.create_foreign_key('flags_ibfk_1', 'flags', 'challenges', ['challenge_id'], ['id'])
op.drop_constraint('files_ibfk_1', 'files', type_='foreignkey')
op.create_foreign_key('files_ibfk_1', 'files', 'challenges', ['challenge_id'], ['id'])
op.drop_constraint('awards_ibfk_1', 'awards', type_='foreignkey')
op.drop_constraint('awards_ibfk_2', 'awards', type_='foreignkey')
op.create_foreign_key('awards_ibfk_1', 'awards', 'teams', ['team_id'], ['id'])
op.create_foreign_key('awards_ibfk_2', 'awards', 'users', ['user_id'], ['id'])
elif url.startswith('postgres'):
op.drop_constraint('unlocks_team_id_fkey', 'unlocks', type_='foreignkey')
op.drop_constraint('unlocks_user_id_fkey', 'unlocks', type_='foreignkey')
op.create_foreign_key('unlocks_team_id_fkey', 'unlocks', 'teams', ['team_id'], ['id'])
op.create_foreign_key('unlocks_user_id_fkey', 'unlocks', 'users', ['user_id'], ['id'])
op.drop_constraint('tracking_user_id_fkey', 'tracking', type_='foreignkey')
op.create_foreign_key('tracking_user_id_fkey', 'tracking', 'users', ['user_id'], ['id'])
op.drop_constraint('team_captain_id', 'teams', type_='foreignkey')
op.create_foreign_key('team_captain_id', 'teams', 'users', ['captain_id'], ['id'])
op.drop_constraint('tags_challenge_id_fkey', 'tags', type_='foreignkey')
op.create_foreign_key('tags_challenge_id_fkey', 'tags', 'challenges', ['challenge_id'], ['id'])
op.drop_constraint('hints_challenge_id_fkey', 'hints', type_='foreignkey')
op.create_foreign_key('hints_challenge_id_fkey', 'hints', 'challenges', ['challenge_id'], ['id'])
op.drop_constraint('flags_challenge_id_fkey', 'flags', type_='foreignkey')
op.create_foreign_key('flags_challenge_id_fkey', 'flags', 'challenges', ['challenge_id'], ['id'])
op.drop_constraint('files_challenge_id_fkey', 'files', type_='foreignkey')
op.create_foreign_key('files_challenge_id_fkey', 'files', 'challenges', ['challenge_id'], ['id'])
op.drop_constraint('awards_team_id_fkey', 'awards', type_='foreignkey')
op.drop_constraint('awards_user_id_fkey', 'awards', type_='foreignkey')
op.create_foreign_key('awards_team_id_fkey', 'awards', 'teams', ['team_id'], ['id'])
op.create_foreign_key('awards_user_id_fkey', 'awards', 'users', ['user_id'], ['id'])