From c9de5179661994b1dec5e0ec8dd0621c7ab4e069 Mon Sep 17 00:00:00 2001 From: Kevin Chung Date: Fri, 14 Aug 2020 01:21:04 -0400 Subject: [PATCH] Properly test under other databases with Github Actions --- .github/workflows/lint.yml | 3 ++- .github/workflows/mysql.yml | 2 +- .github/workflows/postgres.yml | 2 +- .github/workflows/sqlite.yml | 2 +- 4 files changed, 5 insertions(+), 4 deletions(-) diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml index 158966af..35477ba6 100644 --- a/.github/workflows/lint.yml +++ b/.github/workflows/lint.yml @@ -11,7 +11,6 @@ jobs: strategy: matrix: python-version: ['3.6'] - TESTING_DATABASE_URL: ['sqlite://'] name: Linting steps: @@ -30,6 +29,8 @@ jobs: - name: Lint run: make lint + env: + TESTING_DATABASE_URL: 'sqlite://' - name: Lint Dockerfile uses: brpaz/hadolint-action@master diff --git a/.github/workflows/mysql.yml b/.github/workflows/mysql.yml index ddfb5db1..7b08e0e0 100644 --- a/.github/workflows/mysql.yml +++ b/.github/workflows/mysql.yml @@ -20,7 +20,6 @@ jobs: strategy: matrix: python-version: ['3.6'] - TESTING_DATABASE_URL: ['mysql+pymysql://root@localhost/ctfd'] name: Python ${{ matrix.python-version }} steps: @@ -43,6 +42,7 @@ jobs: env: AWS_ACCESS_KEY_ID: AKIAIOSFODNN7EXAMPLE AWS_SECRET_ACCESS_KEY: wJalrXUtnFEMI/K7MDENG/bPxRfiCYEXAMPLEKEY + TESTING_DATABASE_URL: 'mysql+pymysql://root@localhost/ctfd' - name: Codecov uses: codecov/codecov-action@v1.0.11 diff --git a/.github/workflows/postgres.yml b/.github/workflows/postgres.yml index 91b62be8..be8dd237 100644 --- a/.github/workflows/postgres.yml +++ b/.github/workflows/postgres.yml @@ -29,7 +29,6 @@ jobs: strategy: matrix: python-version: ['3.6'] - TESTING_DATABASE_URL: ['postgres://postgres@localhost/ctfd'] name: Python ${{ matrix.python-version }} steps: @@ -52,6 +51,7 @@ jobs: env: AWS_ACCESS_KEY_ID: AKIAIOSFODNN7EXAMPLE AWS_SECRET_ACCESS_KEY: wJalrXUtnFEMI/K7MDENG/bPxRfiCYEXAMPLEKEY + TESTING_DATABASE_URL: 'postgres://postgres@localhost/ctfd' - name: Codecov uses: codecov/codecov-action@v1.0.11 diff --git a/.github/workflows/sqlite.yml b/.github/workflows/sqlite.yml index 66af2dad..9c8aec60 100644 --- a/.github/workflows/sqlite.yml +++ b/.github/workflows/sqlite.yml @@ -11,7 +11,6 @@ jobs: strategy: matrix: python-version: ['3.6'] - TESTING_DATABASE_URL: ['sqlite://'] name: Python ${{ matrix.python-version }} steps: @@ -35,6 +34,7 @@ jobs: env: AWS_ACCESS_KEY_ID: AKIAIOSFODNN7EXAMPLE AWS_SECRET_ACCESS_KEY: wJalrXUtnFEMI/K7MDENG/bPxRfiCYEXAMPLEKEY + TESTING_DATABASE_URL: 'sqlite://' - name: Codecov uses: codecov/codecov-action@v1.0.11