aljaz/CTFd
1
0
Fork 0
mirror of https://github.com/aljazceru/CTFd.git synced 2026-01-31 20:04:28 +01:00
Code Issues Packages Projects Releases Wiki Activity

1092 fix solve count leak during freeze (#1095)

Browse Source 
* Challenges properly get solve count during freeze time
* Closes #1092
This commit is contained in:
Kevin Chung
2019-08-29 23:22:24 -04:00
committed by GitHub
parent 941ca8f506
commit c88e0556eb
2 changed files with 22 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
tests/api/v1/test_challenges.py
View File

@@ -536,14 +536,25 @@ def test_api_challenge_get_solves_ctf_frozen():
chal2_id = chal2.id
with freeze_time("2017-10-8"):
chal2 = gen_solve(app.db, user_id=2, challenge_id=chal2_id)
# User ID 2 solves Challenge ID 2
gen_solve(app.db, user_id=2, challenge_id=chal2_id)
# User ID 3 solves Challenge ID 1
gen_solve(app.db, user_id=3, challenge_id=chal_id)
# Challenge 1 has 2 solves
# Challenge 2 has 1 solve
# There should now be two solves assigned to the same user.
assert Solves.query.count() == 2
assert Solves.query.count() == 3
client = login_as_user(app, name="user2")
# Challenge 1 should have one solve
# Challenge 1 should have one solve (after freeze)
r = client.get("/api/v1/challenges/1")
data = r.get_json()["data"]
assert data['solves'] == 1
# Challenge 1 should have one solve (after freeze)
r = client.get("/api/v1/challenges/1/solves")
data = r.get_json()["data"]
assert len(data) == 1