From 5daa85fce6e8600e9ac0ce41c812c2bdc35f355d Mon Sep 17 00:00:00 2001
From: Kevin Chung <kchung@ctfd.io>
Date: Sat, 5 Nov 2022 11:55:40 -0400
Subject: [PATCH] Fix other issues wih missing autocomplete='off' (#2217)

---
 .../admin/templates/modals/teams/create.html  | 16 +++++++--------
 .../admin/templates/modals/teams/edit.html    | 16 +++++++--------
 .../admin/templates/modals/users/create.html  | 20 +++++++++----------
 .../admin/templates/modals/users/edit.html    | 18 ++++++++---------
 CTFd/themes/admin/templates/reset.html        | 10 +++++-----
 CTFd/themes/admin/templates/users/users.html  |  4 ++--
 6 files changed, 42 insertions(+), 42 deletions(-)

diff --git a/CTFd/themes/admin/templates/modals/teams/create.html b/CTFd/themes/admin/templates/modals/teams/create.html
index 7007a2b7..b14b8368 100644
--- a/CTFd/themes/admin/templates/modals/teams/create.html
+++ b/CTFd/themes/admin/templates/modals/teams/create.html
@@ -3,41 +3,41 @@
 <form id="team-info-create-form" method="POST">
 	<div class="form-group">
 		{{ form.name.label }}
-		{{ form.name(class="form-control") }}
+		{{ form.name(class="form-control", autocomplete="off") }}
 	</div>
 	<div class="form-group">
 		{{ form.email.label }}
-		{{ form.email(class="form-control") }}
+		{{ form.email(class="form-control", autocomplete="off") }}
 	</div>
 	<div class="form-group">
 		{{ form.password.label }}
-		{{ form.password(class="form-control") }}
+		{{ form.password(class="form-control", autocomplete="off") }}
 	</div>
 	<div class="form-group">
 		{{ form.website.label }}
 		<small class="float-right text-muted align-text-bottom">Optional</small>
-		{{ form.website(class="form-control") }}
+		{{ form.website(class="form-control", autocomplete="off") }}
 	</div>
 	<div class="form-group">
 		{{ form.affiliation.label }}
 		<small class="float-right text-muted align-text-bottom">Optional</small>
-		{{ form.affiliation(class="form-control") }}
+		{{ form.affiliation(class="form-control", autocomplete="off") }}
 	</div>
 	<div class="form-group">
 		{{ form.country.label }}
 		<small class="float-right text-muted align-text-bottom">Optional</small>
-		{{ form.country(class="form-control custom-select") }}
+		{{ form.country(class="form-control custom-select", autocomplete="off") }}
 	</div>
 
 	{{ render_extra_fields(form.extra) }}
 
 	<div class="form-group">
 		<div class="form-check form-check-inline">
-			{{ form.hidden(class="form-check-input") }}
+			{{ form.hidden(class="form-check-input", autocomplete="off") }}
 			{{ form.hidden.label(class="form-check-label") }}
 		</div>
 		<div class="form-check form-check-inline">
-			{{ form.banned(class="form-check-input") }}
+			{{ form.banned(class="form-check-input", autocomplete="off") }}
 			{{ form.banned.label(class="form-check-label") }}
 		</div>
 	</div>
diff --git a/CTFd/themes/admin/templates/modals/teams/edit.html b/CTFd/themes/admin/templates/modals/teams/edit.html
index 3823cb9c..ae41a467 100644
--- a/CTFd/themes/admin/templates/modals/teams/edit.html
+++ b/CTFd/themes/admin/templates/modals/teams/edit.html
@@ -3,38 +3,38 @@
 <form id="team-info-edit-form" method="POST">
 	<div class="form-group">
 		{{ form.name.label }}
-		{{ form.name(class="form-control") }}
+		{{ form.name(class="form-control", autocomplete="off") }}
 	</div>
 	<div class="form-group">
 		{{ form.email.label }}
-		{{ form.email(class="form-control") }}
+		{{ form.email(class="form-control", autocomplete="off") }}
 	</div>
 	<div class="form-group">
 		{{ form.password.label }}
-		{{ form.password(class="form-control") }}
+		{{ form.password(class="form-control", autocomplete="off") }}
 	</div>
 	<div class="form-group">
 		{{ form.website.label }}
-		{{ form.website(class="form-control") }}
+		{{ form.website(class="form-control", autocomplete="off") }}
 	</div>
 	<div class="form-group">
 		{{ form.affiliation.label }}
-		{{ form.affiliation(class="form-control") }}
+		{{ form.affiliation(class="form-control", autocomplete="off") }}
 	</div>
 	<div class="form-group">
 		{{ form.country.label }}
-		{{ form.country(class="form-control custom-select") }}
+		{{ form.country(class="form-control custom-select", autocomplete="off") }}
 	</div>
 
 	{{ render_extra_fields(form.extra) }}
 
 	<div class="form-group">
 		<div class="form-check form-check-inline">
-			{{ form.hidden(class="form-check-input") }}
+			{{ form.hidden(class="form-check-input", autocomplete="off") }}
 			{{ form.hidden.label(class="form-check-label") }}
 		</div>
 		<div class="form-check form-check-inline">
-			{{ form.banned(class="form-check-input") }}
+			{{ form.banned(class="form-check-input", autocomplete="off") }}
 			{{ form.banned.label(class="form-check-label") }}
 		</div>
 	</div>
diff --git a/CTFd/themes/admin/templates/modals/users/create.html b/CTFd/themes/admin/templates/modals/users/create.html
index 1c60d9e0..0a024a84 100644
--- a/CTFd/themes/admin/templates/modals/users/create.html
+++ b/CTFd/themes/admin/templates/modals/users/create.html
@@ -3,30 +3,30 @@
 <form id="user-info-create-form" method="POST">
 	<div class="form-group">
 		{{ form.name.label }}
-		{{ form.name(class="form-control") }}
+		{{ form.name(class="form-control", autocomplete="off") }}
 	</div>
 	<div class="form-group">
 		{{ form.email.label }}
-		{{ form.email(class="form-control") }}
+		{{ form.email(class="form-control", autocomplete="off") }}
 	</div>
 	<div class="form-group">
 		{{ form.password.label }}
-		{{ form.password(class="form-control") }}
+		{{ form.password(class="form-control", autocomplete="off") }}
 	</div>
 	<div class="form-group">
 		{{ form.website.label }}
 		<small class="float-right text-muted align-text-bottom">Optional</small>
-		{{ form.website(class="form-control") }}
+		{{ form.website(class="form-control", autocomplete="off") }}
 	</div>
 	<div class="form-group">
 		{{ form.affiliation.label }}
 		<small class="float-right text-muted align-text-bottom">Optional</small>
-		{{ form.affiliation(class="form-control") }}
+		{{ form.affiliation(class="form-control", autocomplete="off") }}
 	</div>
 	<div class="form-group">
 		{{ form.country.label }}
 		<small class="float-right text-muted align-text-bottom">Optional</small>
-		{{ form.country(class="form-control custom-select") }}
+		{{ form.country(class="form-control custom-select", autocomplete="off") }}
 	</div>
 
 	{{ render_extra_fields(form.extra) }}
@@ -36,15 +36,15 @@
 			{{ form.type(class="form-control form-inline custom-select", id="type-select") }}
 		</div>
 		<div class="form-check form-check-inline">
-			{{ form.verified(class="form-check-input") }}
+			{{ form.verified(class="form-check-input", autocomplete="off") }}
 			{{ form.verified.label(class="form-check-label") }}
 		</div>
 		<div class="form-check form-check-inline">
-			{{ form.hidden(class="form-check-input") }}
+			{{ form.hidden(class="form-check-input", autocomplete="off") }}
 			{{ form.hidden.label(class="form-check-label") }}
 		</div>
 		<div class="form-check form-check-inline">
-			{{ form.banned(class="form-check-input") }}
+			{{ form.banned(class="form-check-input", autocomplete="off") }}
 			{{ form.banned.label(class="form-check-label") }}
 		</div>
 	</div>
@@ -52,7 +52,7 @@
 	{% if can_send_mail() %}
 	<div class="form-group">
 		<div class="form-check form-check-inline">
-			{{ form.notify(class="form-check-input", id="notify") }}
+			{{ form.notify(class="form-check-input", id="notify", autocomplete="off") }}
 			{{ form.notify.label(class="form-check-label") }}
 		</div>
 	</div>
diff --git a/CTFd/themes/admin/templates/modals/users/edit.html b/CTFd/themes/admin/templates/modals/users/edit.html
index 67915064..6149ff75 100644
--- a/CTFd/themes/admin/templates/modals/users/edit.html
+++ b/CTFd/themes/admin/templates/modals/users/edit.html
@@ -3,27 +3,27 @@
 <form id="user-info-edit-form">
 	<div class="form-group">
 		{{ form.name.label }}
-		{{ form.name(class="form-control") }}
+		{{ form.name(class="form-control", autocomplete="off") }}
 	</div>
 	<div class="form-group">
 		{{ form.email.label }}
-		{{ form.email(class="form-control") }}
+		{{ form.email(class="form-control", autocomplete="off") }}
 	</div>
 	<div class="form-group">
 		{{ form.password.label }}
-		{{ form.password(class="form-control") }}
+		{{ form.password(class="form-control", autocomplete="off") }}
 	</div>
 	<div class="form-group">
 		{{ form.website.label }}
-		{{ form.website(class="form-control") }}
+		{{ form.website(class="form-control", autocomplete="off") }}
 	</div>
 	<div class="form-group">
 		{{ form.affiliation.label }}
-		{{ form.affiliation(class="form-control") }}
+		{{ form.affiliation(class="form-control", autocomplete="off") }}
 	</div>
 	<div class="form-group">
 		{{ form.country.label }}
-		{{ form.country(class="form-control custom-select") }}
+		{{ form.country(class="form-control custom-select", autocomplete="off") }}
 	</div>
 
 	{{ render_extra_fields(form.extra) }}
@@ -33,15 +33,15 @@
 			{{ form.type(class="form-control form-inline custom-select", id="type-select") }}
 		</div>
 		<div class="form-check form-check-inline">
-			{{ form.verified(class="form-check-input") }}
+			{{ form.verified(class="form-check-input", autocomplete="off") }}
 			{{ form.verified.label(class="form-check-label") }}
 		</div>
 		<div class="form-check form-check-inline">
-			{{ form.hidden(class="form-check-input") }}
+			{{ form.hidden(class="form-check-input", autocomplete="off") }}
 			{{ form.hidden.label(class="form-check-label") }}
 		</div>
 		<div class="form-check form-check-inline">
-			{{ form.banned(class="form-check-input") }}
+			{{ form.banned(class="form-check-input", autocomplete="off") }}
 			{{ form.banned.label(class="form-check-label") }}
 		</div>
 	</div>
diff --git a/CTFd/themes/admin/templates/reset.html b/CTFd/themes/admin/templates/reset.html
index 27ffb4fe..835fc234 100644
--- a/CTFd/themes/admin/templates/reset.html
+++ b/CTFd/themes/admin/templates/reset.html
@@ -39,7 +39,7 @@
 
 					<div class="form-group pb-2">
 						<div class="form-check">
-							{{ form.accounts(class="form-check-input") }}
+							{{ form.accounts(class="form-check-input", autocomplete="off") }}
 							{{ form.accounts.label(class="form-check-label") }}
 						</div>
 						<span class="text-muted">
@@ -50,7 +50,7 @@
 
 					<div class="form-group pb-2">
 						<div class="form-check">
-							{{ form.submissions(class="form-check-input") }}
+							{{ form.submissions(class="form-check-input", autocomplete="off") }}
 							{{ form.submissions.label(class="form-check-label") }}
 						</div>
 						<span class="text-muted">
@@ -61,7 +61,7 @@
 
 					<div class="form-group pb-2">
 						<div class="form-check">
-							{{ form.challenges(class="form-check-input") }}
+							{{ form.challenges(class="form-check-input", autocomplete="off") }}
 							{{ form.challenges.label(class="form-check-label") }}
 						</div>
 						<span class="text-muted">
@@ -72,7 +72,7 @@
 
 					<div class="form-group pb-2">
 						<div class="form-check">
-							{{ form.pages(class="form-check-input") }}
+							{{ form.pages(class="form-check-input", autocomplete="off") }}
 							{{ form.pages.label(class="form-check-label") }}
 						</div>
 						<span class="text-muted">
@@ -83,7 +83,7 @@
 
 					<div class="form-group pb-2">
 						<div class="form-check">
-							{{ form.notifications(class="form-check-input") }}
+							{{ form.notifications(class="form-check-input", autocomplete="off") }}
 							{{ form.notifications.label(class="form-check-label") }}
 						</div>
 						<span class="text-muted">
diff --git a/CTFd/themes/admin/templates/users/users.html b/CTFd/themes/admin/templates/users/users.html
index 28cfbdea..896cebb4 100644
--- a/CTFd/themes/admin/templates/users/users.html
+++ b/CTFd/themes/admin/templates/users/users.html
@@ -70,7 +70,7 @@
 					<tr>
 						<th class="border-right" data-checkbox>
 							<div class="form-check text-center">
-								<input type="checkbox" class="form-check-input" data-checkbox-all>&nbsp;
+								<input type="checkbox" class="form-check-input" autocomplete="off" data-checkbox-all>&nbsp;
 							</div>
 						</th>
 						<th class="sort-col text-center"><b>ID</b></th>
@@ -88,7 +88,7 @@
 					<tr name="{{ user.id }}" data-href="{{ url_for('admin.users_detail', user_id=user.id) }}">
 						<td class="border-right" data-checkbox>
 							<div class="form-check text-center">
-								<input type="checkbox" class="form-check-input" value="{{ user.id }}" data-user-id="{{ user.id }}">&nbsp;
+								<input type="checkbox" class="form-check-input" autocomplete="off" value="{{ user.id }}" data-user-id="{{ user.id }}">&nbsp;
 							</div>
 						</td>
 						<td class="team-id text-center" value="{{ user.id }}">{{ user.id }}</td>