Remove invalid id='submit' on submit buttons and correctly set tabindex to 0 (#1080)

* Remove invalid id='submit' on submit buttons
* Set `tabindex` to 0 since we don't really care for forcing tab order.
This commit is contained in:
Kevin Chung
2019-08-08 18:27:44 -04:00
committed by GitHub
parent 71240bb13d
commit 5c4f1d78fa
10 changed files with 10 additions and 10 deletions

View File

@@ -79,7 +79,7 @@
<input id="challenge-id" type="hidden" value="{{ id }}"> <input id="challenge-id" type="hidden" value="{{ id }}">
</div> </div>
<div class="col-md-3 form-group key-submit"> <div class="col-md-3 form-group key-submit">
<button type="submit" id="submit-key" tabindex="5" <button type="submit" id="submit-key" tabindex="0"
class="btn btn-md btn-outline-secondary float-right">Submit class="btn btn-md btn-outline-secondary float-right">Submit
</button> </button>
</div> </div>

View File

@@ -80,7 +80,7 @@
<input id="challenge-id" type="hidden" value="{{ id }}"> <input id="challenge-id" type="hidden" value="{{ id }}">
</div> </div>
<div class="col-md-3 form-group key-submit"> <div class="col-md-3 form-group key-submit">
<button type="submit" id="submit-key" tabindex="5" <button type="submit" id="submit-key" tabindex="0"
class="btn btn-md btn-outline-secondary float-right">Submit class="btn btn-md btn-outline-secondary float-right">Submit
</button> </button>
</div> </div>

View File

@@ -48,7 +48,7 @@
Need to resend the confirmation email? Need to resend the confirmation email?
</h4> </h4>
<div class="col-md-12 text-center"> <div class="col-md-12 text-center">
<button type="submit" id="submit" tabindex="5" class="btn btn-md btn-primary btn-outlined">Resend</button> <button type="submit" tabindex="0" class="btn btn-md btn-primary btn-outlined">Resend</button>
</div> </div>
<input type="hidden" name="nonce" value="{{ nonce }}"> <input type="hidden" name="nonce" value="{{ nonce }}">
</form> </form>

View File

@@ -45,7 +45,7 @@
</a> </a>
</div> </div>
<div class="col-md-6"> <div class="col-md-6">
<button type="submit" id="submit" tabindex="5" class="btn btn-md btn-primary btn-outlined float-right"> <button type="submit" tabindex="0" class="btn btn-md btn-primary btn-outlined float-right">
Submit Submit
</button> </button>
</div> </div>

View File

@@ -45,7 +45,7 @@
</div> </div>
<div class="row pt-3"> <div class="row pt-3">
<div class="col-md-12"> <div class="col-md-12">
<button type="submit" id="submit" tabindex="5" class="btn btn-md btn-primary btn-outlined float-right">Submit</button> <button type="submit" tabindex="0" class="btn btn-md btn-primary btn-outlined float-right">Submit</button>
</div> </div>
</div> </div>
<input type="hidden" name="nonce" value="{{ nonce }}"> <input type="hidden" name="nonce" value="{{ nonce }}">

View File

@@ -39,7 +39,7 @@
{% endif %} {% endif %}
<div class="row"> <div class="row">
<div class="col-md-6 offset-md-6"> <div class="col-md-6 offset-md-6">
<button type="submit" id="submit" tabindex="5" class="btn btn-md btn-primary float-right">Submit</button> <button type="submit" tabindex="0" class="btn btn-md btn-primary float-right">Submit</button>
</div> </div>
</div> </div>
</form> </form>

View File

@@ -84,7 +84,7 @@
</div> </div>
<div class="form-group"> <div class="form-group">
<button type="submit" id="submit" tabindex="5" class="btn btn-md btn-primary btn-outlined float-right">Submit</button> <button type="submit" tabindex="0" class="btn btn-md btn-primary btn-outlined float-right">Submit</button>
</div> </div>
</form> </form>
</div> </div>

View File

@@ -77,7 +77,7 @@
</div> </div>
<br/> <br/>
<div class="submit-row text-center"> <div class="submit-row text-center">
<button type="submit" id="submit" tabindex="5" class="btn btn-md btn-primary btn-outlined">Submit <button type="submit" tabindex="0" class="btn btn-md btn-primary btn-outlined">Submit
</button> </button>
</div> </div>
</form> </form>

View File

@@ -32,7 +32,7 @@
<input type="hidden" name="nonce" value="{{ nonce }}"> <input type="hidden" name="nonce" value="{{ nonce }}">
<div class="row pt-3"> <div class="row pt-3">
<div class="col-md-12"> <div class="col-md-12">
<button type="submit" id="submit" class="btn btn-success float-right"> <button type="submit" class="btn btn-success float-right">
Join Join
</button> </button>
</div> </div>

View File

@@ -33,7 +33,7 @@
<div class="row pt-3"> <div class="row pt-3">
<div class="col-md-12"> <div class="col-md-12">
<p>After creating your team, share the team name and password with your teammates so they can join your team.</p> <p>After creating your team, share the team name and password with your teammates so they can join your team.</p>
<button type="submit" id="submit" class="btn btn-success float-right"> <button type="submit" class="btn btn-success float-right">
Create Create
</button> </button>
</div> </div>