Update admin notification UI and allow for deleting notifications (#803)

* Show notification titles on the notification list page
* Allow for deleting notifications
* Update notification UI in admin panel
* Make /api/v1/notifications/<id> accessible to all
* Default `login_as_user()` and `register_user()` to fail on invalid credentials

tests/api/v1/test_notifications.py

@@ -8,9 +8,26 @@ def test_api_notifications_get():
     """Can the users get /api/v1/notifications"""
     app = create_ctfd()
     with app.app_context():
+        register_user(app)
+        gen_notification(app.db)
         with login_as_user(app) as client:
             r = client.get('/api/v1/notifications', json="")
             assert r.status_code == 200
+            assert len(r.get_json()['data']) == 1
+    destroy_ctfd(app)
+
+
+def test_api_get_notification_detail():
+    app = create_ctfd()
+    with app.app_context():
+        register_user(app)
+        gen_notification(app.db)
+        with login_as_user(app) as client:
+            r = client.get('/api/v1/notifications/1', json="")
+            assert r.status_code == 200
+            resp = r.get_json()
+            assert resp['data']['title'] == 'title'
+            assert resp['data']['content'] == 'content'
     destroy_ctfd(app)
 
 
@@ -18,6 +35,7 @@ def test_api_notifications_post_non_admin():
     """Can the users post /api/v1/notifications if not admin"""
     app = create_ctfd()
     with app.app_context():
+        register_user(app)
         with login_as_user(app) as client:
             r = client.post('/api/v1/notifications', json="")
             assert r.status_code == 403
@@ -35,3 +53,33 @@ def test_api_notifications_post_admin():
                 "content": "content"})
             assert r.status_code == 200
     destroy_ctfd(app)
+
+
+def test_api_delete_notifications_by_admin():
+    """Test that an admin can delete notifications"""
+    app = create_ctfd()
+    with app.app_context():
+        gen_challenge(app.db)
+        gen_notification(app.db)
+        assert Notifications.query.count() == 1
+        with login_as_user(app, name="admin") as client:
+            r = client.delete('/api/v1/notifications/1', json="")
+            assert r.status_code == 200
+            assert r.get_json()['success'] is True
+        assert Notifications.query.count() == 0
+    destroy_ctfd(app)
+
+
+def test_api_delete_notifications_by_user():
+    """Test that a non-admin cannot delete notifications"""
+    app = create_ctfd()
+    with app.app_context():
+        register_user(app)
+        gen_challenge(app.db)
+        gen_notification(app.db)
+        assert Notifications.query.count() == 1
+        with login_as_user(app) as client:
+            r = client.delete('/api/v1/notifications/1', json="")
+            assert r.status_code == 403
+        assert Notifications.query.count() == 1
+    destroy_ctfd(app)