Flaky redis events tests (#1072)

* Fix flaky redis tests
* Add a random integer helper for tests
This commit is contained in:
Kevin Chung
2019-07-30 03:25:29 -04:00
committed by GitHub
parent 34bab12a99
commit 3453eafcab
2 changed files with 13 additions and 9 deletions

View File

@@ -239,6 +239,10 @@ def random_string(n=5):
)
def random_int(start=2147483647, stop=None, step=1):
return random.randrange(start, stop, step)
def gen_challenge(
db,
name="chal_name",

View File

@@ -89,10 +89,10 @@ def test_event_endpoint_is_event_stream():
def test_redis_event_manager_installed():
"""Test that RedisEventManager is installed on the Flask app"""
# TODO: This test is flaky.
class RedisConfig(TestingConfig):
REDIS_URL = "redis://localhost:6379"
CACHE_REDIS_URL = "redis://localhost:6379"
REDIS_URL = "redis://localhost:6379/1"
CACHE_REDIS_URL = "redis://localhost:6379/1"
CACHE_TYPE = "redis"
try:
@@ -107,10 +107,10 @@ def test_redis_event_manager_installed():
def test_redis_event_manager_subscription():
"""Test that RedisEventManager subscribing works."""
# TODO: This test is flaky.
class RedisConfig(TestingConfig):
REDIS_URL = "redis://localhost:6379"
CACHE_REDIS_URL = "redis://localhost:6379"
REDIS_URL = "redis://localhost:6379/2"
CACHE_REDIS_URL = "redis://localhost:6379/2"
CACHE_TYPE = "redis"
try:
@@ -152,10 +152,10 @@ def test_redis_event_manager_subscription():
def test_redis_event_manager_publish():
"""Test that RedisEventManager publishing to clients works."""
# TODO: This test is flaky.
class RedisConfig(TestingConfig):
REDIS_URL = "redis://localhost:6379"
CACHE_REDIS_URL = "redis://localhost:6379"
REDIS_URL = "redis://localhost:6379/3"
CACHE_REDIS_URL = "redis://localhost:6379/3"
CACHE_TYPE = "redis"
try: