aljaz/CTFd
1
0
Fork 0
mirror of https://github.com/aljazceru/CTFd.git synced 2025-12-18 06:24:23 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fix creating users from the admin panel while name changes disabled (#862)

Browse Source 
* Fix creating users from the admin panel while name changes are disabled; clean up user & team schema validators
* Closes #832
* Coerce /api/v1/teams/<team_id> to /api/v1/teams/<int:team_id>
This commit is contained in:
Kevin Chung
2019-01-31 01:18:46 -05:00
committed by GitHub
parent 2935a76722
commit 2f49477465
7 changed files with 178 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files

46
tests/api/v1/test_teams.py
View File

@@ -109,6 +109,50 @@ def test_api_teams_post_admin():
destroy_ctfd(app)
def test_api_teams_post_admin_duplicate():
"""Test that admins can only create teams with unique information"""
app = create_ctfd(user_mode="teams")
with app.app_context():
gen_team(app.db, name='team1')
with login_as_user(app, 'admin') as client:
# Duplicate name
r = client.post(
'/api/v1/teams',
json={
"website": "https://ctfd.io",
"name": "team1",
"country": "TW",
"email": "team1@ctfd.io",
"affiliation": "team",
"password": "password"
}
)
resp = r.get_json()
assert r.status_code == 400
assert resp['errors']['name']
assert resp['success'] is False
assert Teams.query.count() == 1
# Duplicate email
r = client.post(
'/api/v1/teams',
json={
"website": "https://ctfd.io",
"name": "new_team",
"country": "TW",
"email": "team@ctfd.io",
"affiliation": "team",
"password": "password"
}
)
resp = r.get_json()
assert r.status_code == 400
assert resp['errors']['email']
assert resp['success'] is False
assert Teams.query.count() == 1
destroy_ctfd(app)
def test_api_team_get_public():
"""Can a user get /api/v1/team/<team_id> if teams are public"""
app = create_ctfd(user_mode="teams")
@@ -184,6 +228,7 @@ def test_api_team_patch_admin():
with login_as_user(app, 'admin') as client:
r = client.patch('/api/v1/teams/1', json={
"name": "team_name",
"email": "team@ctfd.io",
"password": "password",
"affiliation": "changed"
})
@@ -191,7 +236,6 @@ def test_api_team_patch_admin():
assert r.status_code == 200
assert r.get_json()['data']['affiliation'] == 'changed'
assert verify_password('password', team.password)
destroy_ctfd(app)