Change challenge visibility badge on challenge update (#1331)

* Refresh challenge visibility badge after challenge update. A stopgap solution until a better state based UI is implemented. 
* Closes #1267

CTFd/themes/admin/assets/js/pages/challenge.js

@@ -407,8 +407,23 @@ $(() => {
             .then(function(response) {
               return response.json();
             })
-            .then(function(data) {
+            .then(function(response) {
-              if (data.success) {
+              if (response.success) {
+                $(".challenge-state").text(response.data.state);
+                switch (response.data.state) {
+                  case "visible":
+                    $(".challenge-state")
+                      .removeClass("badge-danger")
+                      .addClass("badge-success");
+                    break;
+                  case "hidden":
+                    $(".challenge-state")
+                      .removeClass("badge-success")
+                      .addClass("badge-danger");
+                    break;
+                  default:
+                    break;
+                }
                 ezToast({
                   title: "Success",
                   body: "Your challenge has been updated!"

CTFd/themes/admin/templates/challenges/challenge.html

@@ -19,7 +19,7 @@
 			<h2 class="text-center">{{ challenge.type }}</h2>
 			{% set badge_state = 'badge-danger' if challenge.state == 'hidden' else 'badge-success' %}
 			<h5>
-				<span class="badge {{ badge_state }}">
+				<span class="badge {{ badge_state }} challenge-state">
 					{{ challenge.state }}
 				</span>
 			</h5>