From ec262f0667f1b78dea39904e94d7cfceb8028672 Mon Sep 17 00:00:00 2001
From: merwanehamadi <merwanehamadi@gmail.com>
Date: Fri, 4 Aug 2023 15:07:15 -0700
Subject: [PATCH] Fix more attempted metrics not working (#252)

Signed-off-by: Merwane Hamadi <merwanehamadi@gmail.com>
---
 agbenchmark/reports/reports.py | 15 ++++++++++++---
 1 file changed, 12 insertions(+), 3 deletions(-)

diff --git a/agbenchmark/reports/reports.py b/agbenchmark/reports/reports.py
index 4891aa3e..27d17589 100644
--- a/agbenchmark/reports/reports.py
+++ b/agbenchmark/reports/reports.py
@@ -65,7 +65,7 @@ def generate_combined_suite_report(
             "metrics": {
                 "difficulty": raw_difficulty.value,
                 "success": False,
-                "attempted": True,
+                "attempted": False,
             },
         }
 
@@ -73,6 +73,7 @@ def generate_combined_suite_report(
             # add dependency successful here
 
             test_info_details["metrics"]["success"] = True
+            test_info_details["metrics"]["attempted"] = True
 
             # replace the highest difficulty if needed
             if DIFFICULTY_MAP[raw_difficulty] > num_highest_difficulty:
@@ -101,7 +102,6 @@ def generate_combined_suite_report(
         "metrics": {
             "percentage": scores.get("percentage", 0),
             "highest_difficulty": str_highest_difficulty,
-            "attempted": True,
         },
         "tests": tests,
     }
@@ -168,7 +168,11 @@ def generate_single_call_report(
         "task": challenge_data["task"],
         "answer": challenge_data["ground"]["answer"],
         "description": challenge_data["info"]["description"],
-        "metrics": {"difficulty": difficulty, "success": False, "attempted": True},
+        "metrics": {
+            "difficulty": difficulty,
+            "success": False,
+            "attempted": True,
+        },
     }
 
     mock = "--mock" in sys.argv  # Check if --mock is in sys.argv
@@ -245,6 +249,11 @@ def finalize_reports(item: Any, challenge_data: dict[str, Any]) -> None:
             if info_details["metrics"].get("success", None) is None:
                 info_details["metrics"]["attempted"] = False
                 info_details["metrics"]["success"] = False
+            elif (
+                info_details["metrics"].get("success") is False
+                and "attempted" not in info_details["metrics"]
+            ):
+                info_details["metrics"]["attempted"] = False
 
             info_details["metrics"]["run_time"] = f"{str(round(run_time, 3))} seconds"