From 48f6f83f05d6320282a42da47d03afcfe9875d75 Mon Sep 17 00:00:00 2001 From: Reinier van der Leer Date: Fri, 1 Mar 2024 10:35:28 +0100 Subject: [PATCH] ci(arena): Fix `arena-intake` workflow --- .github/workflows/arena-intake.yml | 37 ++++++++++++++++++------------ 1 file changed, 22 insertions(+), 15 deletions(-) diff --git a/.github/workflows/arena-intake.yml b/.github/workflows/arena-intake.yml index 5a76493c..8ecd6768 100644 --- a/.github/workflows/arena-intake.yml +++ b/.github/workflows/arena-intake.yml @@ -78,7 +78,6 @@ jobs: && newArenaFile.status != 'added' ) { flagForManualCheck = true; - break; } const arenaEntry = JSON.parse(fs.readFileSync(file)); @@ -100,12 +99,21 @@ jobs: } // end if (arenaFilesChanged.length === 1) if (issues.length == 0) { - await github.rest.pulls.createReview({ - owner: github.context.repo.owner, - repo: github.context.repo.repo, - pull_number: pr.number, - event: 'APPROVE', - }); + if (flagForManualCheck) { + await github.rest.pulls.requestReviewers({ + owner: github.context.repo.owner, + repo: github.context.repo.repo, + pull_number: pr.number, + team_reviewers: ['maintainers'], + }); + } else { + await github.rest.pulls.createReview({ + owner: github.context.repo.owner, + repo: github.context.repo.repo, + pull_number: pr.number, + event: 'APPROVE', + }); + } } else { await github.rest.issues.createComment({ owner: github.context.repo.owner, @@ -114,6 +122,12 @@ jobs: body: `Our automation found one or more issues with this submission:\n` + issues.map(i => `- ${i.replace('\n', '\n ')}`).join('\n'), }); + await github.rest.issues.addLabels({ + owner: github.context.repo.owner, + repo: github.context.repo.repo, + issue_number: pr.number, + labels: ['invalid'], + }); if (close) { await github.rest.pulls.update({ @@ -122,12 +136,5 @@ jobs: pull_number: pr.number, state: 'closed', }); - } else if (flagForManualCheck) { - await github.rest.pulls.requestReviewers({ - owner: github.context.repo.owner, - repo: github.context.repo.repo, - pull_number: pr.number, - team_reviewers: ['maintainers'], - }); } - } // end else + }