mirror of
https://github.com/aljazceru/Auto-GPT.git
synced 2026-01-10 17:54:22 +01:00
Pass agent to commands instead of config (#4645)
* Add config as attribute to Agent, rename old config to ai_config * Code review: Pass ai_config * Pass agent to commands instead of config * Lint * Fix merge error * Fix memory challenge a --------- Co-authored-by: Nicholas Tindle <nick@ntindle.com> Co-authored-by: merwanehamadi <merwanehamadi@gmail.com>
This commit is contained in:
@@ -7,8 +7,8 @@ from typing import Callable
|
||||
import pytest
|
||||
|
||||
import autogpt.commands.execute_code as sut # system under testing
|
||||
from autogpt.agent.agent import Agent
|
||||
from autogpt.config import Config
|
||||
from autogpt.config.ai_config import AIConfig
|
||||
|
||||
|
||||
@pytest.fixture
|
||||
@@ -31,54 +31,54 @@ def random_string():
|
||||
return "".join(random.choice(string.ascii_lowercase) for _ in range(10))
|
||||
|
||||
|
||||
def test_execute_python_file(python_test_file: str, random_string: str, config):
|
||||
result: str = sut.execute_python_file(python_test_file, config)
|
||||
def test_execute_python_file(python_test_file: str, random_string: str, agent: Agent):
|
||||
result: str = sut.execute_python_file(python_test_file, agent=agent)
|
||||
assert result.replace("\r", "") == f"Hello {random_string}!\n"
|
||||
|
||||
|
||||
def test_execute_python_code(random_code: str, random_string: str, config: Config):
|
||||
ai_name = AIConfig.load(config.ai_settings_file).ai_name
|
||||
def test_execute_python_code(random_code: str, random_string: str, agent: Agent):
|
||||
ai_name = agent.ai_name
|
||||
|
||||
result: str = sut.execute_python_code(random_code, "test_code", config)
|
||||
result: str = sut.execute_python_code(random_code, "test_code", agent=agent)
|
||||
assert result.replace("\r", "") == f"Hello {random_string}!\n"
|
||||
|
||||
# Check that the code is stored
|
||||
destination = os.path.join(
|
||||
config.workspace_path, ai_name, "executed_code", "test_code.py"
|
||||
agent.config.workspace_path, ai_name, "executed_code", "test_code.py"
|
||||
)
|
||||
with open(destination) as f:
|
||||
assert f.read() == random_code
|
||||
|
||||
|
||||
def test_execute_python_code_overwrites_file(
|
||||
random_code: str, random_string: str, config: Config
|
||||
random_code: str, random_string: str, agent: Agent
|
||||
):
|
||||
ai_name = AIConfig.load(config.ai_settings_file).ai_name
|
||||
ai_name = agent.ai_name
|
||||
destination = os.path.join(
|
||||
config.workspace_path, ai_name, "executed_code", "test_code.py"
|
||||
agent.config.workspace_path, ai_name, "executed_code", "test_code.py"
|
||||
)
|
||||
os.makedirs(os.path.dirname(destination), exist_ok=True)
|
||||
|
||||
with open(destination, "w+") as f:
|
||||
f.write("This will be overwritten")
|
||||
|
||||
sut.execute_python_code(random_code, "test_code.py", config)
|
||||
sut.execute_python_code(random_code, "test_code.py", agent=agent)
|
||||
|
||||
# Check that the file is updated with the new code
|
||||
with open(destination) as f:
|
||||
assert f.read() == random_code
|
||||
|
||||
|
||||
def test_execute_python_file_invalid(config: Config):
|
||||
def test_execute_python_file_invalid(agent: Agent):
|
||||
assert all(
|
||||
s in sut.execute_python_file("not_python", config).lower()
|
||||
s in sut.execute_python_file("not_python", agent).lower()
|
||||
for s in ["error:", "invalid", ".py"]
|
||||
)
|
||||
|
||||
|
||||
def test_execute_python_file_not_found(config: Config):
|
||||
def test_execute_python_file_not_found(agent: Agent):
|
||||
assert all(
|
||||
s in sut.execute_python_file("notexist.py", config).lower()
|
||||
s in sut.execute_python_file("notexist.py", agent).lower()
|
||||
for s in [
|
||||
"python: can't open file 'notexist.py'",
|
||||
"[errno 2] no such file or directory",
|
||||
@@ -86,43 +86,43 @@ def test_execute_python_file_not_found(config: Config):
|
||||
)
|
||||
|
||||
|
||||
def test_execute_shell(random_string: str, config: Config):
|
||||
result = sut.execute_shell(f"echo 'Hello {random_string}!'", config)
|
||||
def test_execute_shell(random_string: str, agent: Agent):
|
||||
result = sut.execute_shell(f"echo 'Hello {random_string}!'", agent)
|
||||
assert f"Hello {random_string}!" in result
|
||||
|
||||
|
||||
def test_execute_shell_local_commands_not_allowed(random_string: str, config: Config):
|
||||
result = sut.execute_shell(f"echo 'Hello {random_string}!'", config)
|
||||
def test_execute_shell_local_commands_not_allowed(random_string: str, agent: Agent):
|
||||
result = sut.execute_shell(f"echo 'Hello {random_string}!'", agent)
|
||||
assert f"Hello {random_string}!" in result
|
||||
|
||||
|
||||
def test_execute_shell_denylist_should_deny(config: Config, random_string: str):
|
||||
config.shell_denylist = ["echo"]
|
||||
def test_execute_shell_denylist_should_deny(agent: Agent, random_string: str):
|
||||
agent.config.shell_denylist = ["echo"]
|
||||
|
||||
result = sut.execute_shell(f"echo 'Hello {random_string}!'", config)
|
||||
result = sut.execute_shell(f"echo 'Hello {random_string}!'", agent)
|
||||
assert "Error:" in result and "not allowed" in result
|
||||
|
||||
|
||||
def test_execute_shell_denylist_should_allow(config: Config, random_string: str):
|
||||
config.shell_denylist = ["cat"]
|
||||
def test_execute_shell_denylist_should_allow(agent: Agent, random_string: str):
|
||||
agent.config.shell_denylist = ["cat"]
|
||||
|
||||
result = sut.execute_shell(f"echo 'Hello {random_string}!'", config)
|
||||
result = sut.execute_shell(f"echo 'Hello {random_string}!'", agent)
|
||||
assert "Hello" in result and random_string in result
|
||||
assert "Error" not in result
|
||||
|
||||
|
||||
def test_execute_shell_allowlist_should_deny(config: Config, random_string: str):
|
||||
config.shell_command_control = sut.ALLOWLIST_CONTROL
|
||||
config.shell_allowlist = ["cat"]
|
||||
def test_execute_shell_allowlist_should_deny(agent: Agent, random_string: str):
|
||||
agent.config.shell_command_control = sut.ALLOWLIST_CONTROL
|
||||
agent.config.shell_allowlist = ["cat"]
|
||||
|
||||
result = sut.execute_shell(f"echo 'Hello {random_string}!'", config)
|
||||
result = sut.execute_shell(f"echo 'Hello {random_string}!'", agent)
|
||||
assert "Error:" in result and "not allowed" in result
|
||||
|
||||
|
||||
def test_execute_shell_allowlist_should_allow(config: Config, random_string: str):
|
||||
config.shell_command_control = sut.ALLOWLIST_CONTROL
|
||||
config.shell_allowlist = ["echo"]
|
||||
def test_execute_shell_allowlist_should_allow(agent: Agent, random_string: str):
|
||||
agent.config.shell_command_control = sut.ALLOWLIST_CONTROL
|
||||
agent.config.shell_allowlist = ["echo"]
|
||||
|
||||
result = sut.execute_shell(f"echo 'Hello {random_string}!'", config)
|
||||
result = sut.execute_shell(f"echo 'Hello {random_string}!'", agent)
|
||||
assert "Hello" in result and random_string in result
|
||||
assert "Error" not in result
|
||||
|
||||
Reference in New Issue
Block a user