From c599c20696725d5ce39a2e668f043e6df52fa940 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Sylwester=20Zieli=C5=84ski?= Date: Thu, 31 Mar 2022 14:44:55 +0200 Subject: [PATCH 1/3] Change DFU label depends on DFU app presence. --- app/src/main/AndroidManifest.xml | 10 ++++++++++ .../android/nrftoolbox/MainActivity.kt | 12 ++++++++++++ .../nrftoolbox/repository/ActivitySignals.kt | 17 +++++++++++++++++ .../android/nrftoolbox/view/HomeView.kt | 8 +++++++- .../android/nrftoolbox/view/HomeViewState.kt | 10 ++++++++-- .../nrftoolbox/viewmodel/HomeViewModel.kt | 7 +++++++ app/src/main/res/values/strings.xml | 1 + 7 files changed, 62 insertions(+), 3 deletions(-) create mode 100644 app/src/main/java/no/nordicsemi/android/nrftoolbox/repository/ActivitySignals.kt diff --git a/app/src/main/AndroidManifest.xml b/app/src/main/AndroidManifest.xml index 23422dff..d022eac1 100644 --- a/app/src/main/AndroidManifest.xml +++ b/app/src/main/AndroidManifest.xml @@ -2,6 +2,16 @@ + + + + + + + + + + DFU Device Firmware Update Available in separate application. + Install from Google Play Store. ViewModel profiles Service profiles From b37e11d1cd225d289a1dd92a73e7027e420d05da Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Sylwester=20Zieli=C5=84ski?= Date: Thu, 31 Mar 2022 14:57:12 +0200 Subject: [PATCH 2/3] Change button colors in dark theme --- .../android/nrftoolbox/view/HomeView.kt | 16 ++++++++-------- app/src/main/res/values/strings.xml | 6 +++--- .../android/uart/view/UARTAddMacroDialog.kt | 2 ++ 3 files changed, 13 insertions(+), 11 deletions(-) diff --git a/app/src/main/java/no/nordicsemi/android/nrftoolbox/view/HomeView.kt b/app/src/main/java/no/nordicsemi/android/nrftoolbox/view/HomeView.kt index 7ba809af..99fc714f 100644 --- a/app/src/main/java/no/nordicsemi/android/nrftoolbox/view/HomeView.kt +++ b/app/src/main/java/no/nordicsemi/android/nrftoolbox/view/HomeView.kt @@ -52,14 +52,14 @@ fun HomeScreen() { Spacer(modifier = Modifier.height(16.dp)) - FeatureButton(R.drawable.ic_bps, R.string.bps_module, R.string.bps_module_full) { - viewModel.openProfile(ProfileDestination.BPS) + FeatureButton(R.drawable.ic_gls, R.string.gls_module, R.string.gls_module_full) { + viewModel.openProfile(ProfileDestination.GLS) } Spacer(modifier = Modifier.height(16.dp)) - FeatureButton(R.drawable.ic_gls, R.string.gls_module, R.string.gls_module_full) { - viewModel.openProfile(ProfileDestination.GLS) + FeatureButton(R.drawable.ic_bps, R.string.bps_module, R.string.bps_module_full) { + viewModel.openProfile(ProfileDestination.BPS) } Spacer(modifier = Modifier.height(16.dp)) @@ -96,14 +96,14 @@ fun HomeScreen() { Spacer(modifier = Modifier.height(16.dp)) - FeatureButton(R.drawable.ic_prx, R.string.prx_module, R.string.prx_module_full, state.isPRXModuleRunning) { - viewModel.openProfile(ProfileDestination.PRX) + FeatureButton(R.drawable.ic_cgm, R.string.cgm_module, R.string.cgm_module_full, state.isCGMModuleRunning) { + viewModel.openProfile(ProfileDestination.CGMS) } Spacer(modifier = Modifier.height(16.dp)) - FeatureButton(R.drawable.ic_cgm, R.string.cgm_module, R.string.cgm_module_full, state.isCGMModuleRunning) { - viewModel.openProfile(ProfileDestination.CGMS) + FeatureButton(R.drawable.ic_prx, R.string.prx_module, R.string.prx_module_full, state.isPRXModuleRunning) { + viewModel.openProfile(ProfileDestination.PRX) } Spacer(modifier = Modifier.height(16.dp)) diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml index 8517ced2..e982745d 100644 --- a/app/src/main/res/values/strings.xml +++ b/app/src/main/res/values/strings.xml @@ -16,11 +16,11 @@ CGMS Continuous Glucose UART - Serial port over BLE + Universal Asynchronous Receiver/Transmitter (UART) DFU Device Firmware Update - Available in separate application. - Install from Google Play Store. + Open DFU application. + Download from Google Play. ViewModel profiles Service profiles diff --git a/profile_uart/src/main/java/no/nordicsemi/android/uart/view/UARTAddMacroDialog.kt b/profile_uart/src/main/java/no/nordicsemi/android/uart/view/UARTAddMacroDialog.kt index 8a50932d..b2045215 100644 --- a/profile_uart/src/main/java/no/nordicsemi/android/uart/view/UARTAddMacroDialog.kt +++ b/profile_uart/src/main/java/no/nordicsemi/android/uart/view/UARTAddMacroDialog.kt @@ -22,6 +22,7 @@ import androidx.compose.ui.Alignment import androidx.compose.ui.Modifier import androidx.compose.ui.draw.clip import androidx.compose.ui.graphics.Color +import androidx.compose.ui.graphics.ColorFilter import androidx.compose.ui.res.painterResource import androidx.compose.ui.res.stringResource import androidx.compose.ui.unit.dp @@ -90,6 +91,7 @@ internal fun UARTAddMacroDialog(macro: UARTMacro?, onEvent: (UARTViewEvent) -> U Image( painter = painterResource(id = icon.toResId()), contentDescription = stringResource(id = R.string.uart_macro_icon), + colorFilter = ColorFilter.tint(MaterialTheme.colorScheme.onPrimary), modifier = Modifier .size(40.dp) .clip(RoundedCornerShape(10.dp)) From 047e524f6ea3f8c347e99db4845b7d95f87d26d2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Sylwester=20Zieli=C5=84ski?= Date: Thu, 31 Mar 2022 14:59:36 +0200 Subject: [PATCH 3/3] Improve add configuration dialog --- .../android/uart/view/UARTAddConfigurationDialog.kt | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/profile_uart/src/main/java/no/nordicsemi/android/uart/view/UARTAddConfigurationDialog.kt b/profile_uart/src/main/java/no/nordicsemi/android/uart/view/UARTAddConfigurationDialog.kt index 4f13112c..5e922bd1 100644 --- a/profile_uart/src/main/java/no/nordicsemi/android/uart/view/UARTAddConfigurationDialog.kt +++ b/profile_uart/src/main/java/no/nordicsemi/android/uart/view/UARTAddConfigurationDialog.kt @@ -39,14 +39,10 @@ internal fun UARTAddConfigurationDialog(onEvent: (UARTViewEvent) -> Unit, onDism .padding(16.dp) ) -// Spacer(modifier = Modifier.height(16.dp)) - NameInput(name, isError) -// Spacer(modifier = Modifier.height(16.dp)) - Row( - modifier = Modifier.fillMaxWidth(), + modifier = Modifier.fillMaxWidth().padding(horizontal = 16.dp), horizontalArrangement = Arrangement.End ) { TextButton(onClick = { onDismiss() }) { @@ -96,8 +92,6 @@ private fun NameInput( style = MaterialTheme.typography.labelMedium, color = MaterialTheme.colorScheme.error ) - - Spacer(modifier = Modifier.size(16.dp)) } }